From 59c957fd9856c6d17bcff80a1f3cc8f505ebf035 Mon Sep 17 00:00:00 2001
From: Mike Crute <mike@crute.us>
Date: Tue, 2 Apr 2019 05:49:44 +0000
Subject: Cleanup codacy errors

---
 pandora/errors.py          |  2 +-
 pandora/models/_base.py    |  6 +++---
 pandora/models/ad.py       | 15 +++++++++++++++
 pandora/models/playlist.py | 12 ++++++------
 pydora/audio_backend.py    |  6 ++++++
 5 files changed, 31 insertions(+), 10 deletions(-)

diff --git a/pandora/errors.py b/pandora/errors.py
index b09e813..ba377b5 100644
--- a/pandora/errors.py
+++ b/pandora/errors.py
@@ -56,7 +56,7 @@ class PandoraException(Exception):
 
     def __init__(self, extended_message=""):
         self.extended_message = extended_message
-        super(Exception, self).__init__(self.message)
+        super(PandoraException, self).__init__(self.message)
 
     @classmethod
     def from_code(cls, code, extended_message):
diff --git a/pandora/models/_base.py b/pandora/models/_base.py
index 34ee2f7..214f3c1 100644
--- a/pandora/models/_base.py
+++ b/pandora/models/_base.py
@@ -63,11 +63,11 @@ class DateField(SyntheticField):
     nanosecond precision.
     """
 
-    def formatter(self, api_client, data, value):
-        if not value:
+    def formatter(self, api_client, data, newval):
+        if not newval:
             return None
 
-        return datetime.utcfromtimestamp(value["time"] / 1000)
+        return datetime.utcfromtimestamp(newval["time"] / 1000)
 
 
 class ModelMetaClass(type):
diff --git a/pandora/models/ad.py b/pandora/models/ad.py
index d5bcd89..91820c9 100644
--- a/pandora/models/ad.py
+++ b/pandora/models/ad.py
@@ -34,3 +34,18 @@ class AdItem(PlaylistModel):
             if self.tracking_tokens:
                 raise exc
         return super(AdItem, self).prepare_playback()
+
+    def thumbs_up(self):  # pragma: no cover
+        return
+
+    def thumbs_down(self):  # pragma: no cover
+        return
+
+    def bookmark_song(self):  # pragma: no cover
+        return
+
+    def bookmark_artist(self):  # pragma: no cover
+        return
+
+    def sleep(self):  # pragma: no cover
+        return
diff --git a/pandora/models/playlist.py b/pandora/models/playlist.py
index 08510f1..bd135db 100644
--- a/pandora/models/playlist.py
+++ b/pandora/models/playlist.py
@@ -36,7 +36,7 @@ class PandoraType(Enum):
 
 class AudioField(SyntheticField):
 
-    def formatter(self, api_client, data, value):
+    def formatter(self, api_client, data, newval):
         """Get audio-related fields
 
         Try to find fields for the audio url for specified preferred quality
@@ -85,21 +85,21 @@ class AudioField(SyntheticField):
 
 class AdditionalUrlField(SyntheticField):
 
-    def formatter(self, api_client, data, value):
+    def formatter(self, api_client, data, newval):
         """Parse additional url fields and map them to inputs
 
         Attempt to create a dictionary with keys being user input, and
         response being the returned URL
         """
-        if value is None:
+        if newval is None:
             return None
 
         user_param = data['_paramAdditionalUrls']
         urls = {}
-        if isinstance(value, str):
-            urls[user_param[0]] = value
+        if isinstance(newval, str):
+            urls[user_param[0]] = newval
         else:
-            for key, url in zip(user_param, value):
+            for key, url in zip(user_param, newval):
                 urls[key] = url
         return urls
 
diff --git a/pydora/audio_backend.py b/pydora/audio_backend.py
index 949301e..d39bb9b 100644
--- a/pydora/audio_backend.py
+++ b/pydora/audio_backend.py
@@ -232,6 +232,12 @@ class MPG123Player(BasePlayer):
     def _player_stopped(self, value):
         return value.startswith(b"@P") and value.decode("utf-8")[3] == "0"
 
+    def raise_volume(self):
+        return
+
+    def lower_volume(self):
+        return
+
 
 class VLCPlayer(BasePlayer):
 
-- 
cgit v1.2.3