diff options
author | Sören Tempel <soeren+git@soeren-tempel.net> | 2019-11-14 10:37:52 +0100 |
---|---|---|
committer | Sören Tempel <soeren+git@soeren-tempel.net> | 2019-11-14 10:52:15 +0100 |
commit | 9a4b8f04dafaa8ac635ac285f1ea3123ef510f93 (patch) | |
tree | 78bf45002cbab6ea882ce928c0926e829c5e1574 | |
parent | f0daafa26104492bf41371cccf3a324f02aa66ec (diff) | |
download | alpine_aports-9a4b8f04dafaa8ac635ac285f1ea3123ef510f93.tar.bz2 alpine_aports-9a4b8f04dafaa8ac635ac285f1ea3123ef510f93.tar.xz alpine_aports-9a4b8f04dafaa8ac635ac285f1ea3123ef510f93.zip |
main/abuild: fix abuild rootbld
See https://gitlab.alpinelinux.org/alpine/abuild/issues/9978
-rw-r--r-- | main/abuild/0001-abuild-Fix-abuild-rootbld.patch | 71 | ||||
-rw-r--r-- | main/abuild/APKBUILD | 6 |
2 files changed, 75 insertions, 2 deletions
diff --git a/main/abuild/0001-abuild-Fix-abuild-rootbld.patch b/main/abuild/0001-abuild-Fix-abuild-rootbld.patch new file mode 100644 index 0000000000..18dd4bb36c --- /dev/null +++ b/main/abuild/0001-abuild-Fix-abuild-rootbld.patch | |||
@@ -0,0 +1,71 @@ | |||
1 | From 918b7b19206927b416bcc13bcb80a8f7d2c78c41 Mon Sep 17 00:00:00 2001 | ||
2 | From: =?UTF-8?q?S=C3=B6ren=20Tempel?= <soeren+git@soeren-tempel.net> | ||
3 | Date: Wed, 13 Nov 2019 18:15:28 +0100 | ||
4 | Subject: [PATCH] abuild: Fix abuild rootbld | ||
5 | |||
6 | Without this change abuild rootbld would fail with: | ||
7 | |||
8 | touch: invalid date '@' | ||
9 | |||
10 | Because SOURCE_DATE_EPOCH wasn't set when abuild rootbld was used. This | ||
11 | is a bug introduced in 71d9d5233b9db3be91510addcb28721545d93185. Instead | ||
12 | of reverting the aforementioned commit move the SOURCE_DATE_EPOCH | ||
13 | initialization to a custom function and also call it from the abuild | ||
14 | rootbld function. | ||
15 | |||
16 | Fixes #9978 | ||
17 | --- | ||
18 | abuild.in | 26 +++++++++++++++++--------- | ||
19 | 1 file changed, 17 insertions(+), 9 deletions(-) | ||
20 | |||
21 | diff --git a/abuild.in b/abuild.in | ||
22 | index 91f9e1d..29a87c6 100644 | ||
23 | --- a/abuild.in | ||
24 | +++ b/abuild.in | ||
25 | @@ -104,6 +104,18 @@ want_check() { | ||
26 | return 0 | ||
27 | } | ||
28 | |||
29 | +set_source_date() { | ||
30 | + # set time stamp for reproducible builds | ||
31 | + export ABUILD_LAST_COMMIT="$(git_last_commit)$(git_dirty)" | ||
32 | + if [ -z "$SOURCE_DATE_EPOCH" ] && [ "${ABUILD_LAST_COMMIT%-dirty}" = "$ABUILD_LAST_COMMIT" ]; then | ||
33 | + SOURCE_DATE_EPOCH=$(git_last_commit_epoch $ABUILD_LAST_COMMIT) | ||
34 | + fi | ||
35 | + if [ -z "$SOURCE_DATE_EPOCH" ]; then | ||
36 | + SOURCE_DATE_EPOCH=$(date -u "+%s") | ||
37 | + fi | ||
38 | + export SOURCE_DATE_EPOCH | ||
39 | +} | ||
40 | + | ||
41 | default_cleanup_srcdir() { | ||
42 | if options_has "chmod-clean" && test -d "$srcdir"; then | ||
43 | chmod -R +w "$srcdir" | ||
44 | @@ -1601,15 +1613,8 @@ build_abuildrepo() { | ||
45 | local _starttime=$(date --utc +%s) | ||
46 | msg "Building $repo/$pkgname $pkgver-r$pkgrel (using $program $program_version) started $(date -R)" | ||
47 | |||
48 | - # set time stamp for reproducible builds | ||
49 | - export ABUILD_LAST_COMMIT="$(git_last_commit)$(git_dirty)" | ||
50 | - if [ -z "$SOURCE_DATE_EPOCH" ] && [ "${ABUILD_LAST_COMMIT%-dirty}" = "$ABUILD_LAST_COMMIT" ]; then | ||
51 | - SOURCE_DATE_EPOCH=$(git_last_commit_epoch $ABUILD_LAST_COMMIT) | ||
52 | - fi | ||
53 | - if [ -z "$SOURCE_DATE_EPOCH" ]; then | ||
54 | - SOURCE_DATE_EPOCH=$(date -u "+%s") | ||
55 | - fi | ||
56 | - export SOURCE_DATE_EPOCH | ||
57 | + # make sure SOURCE_DATE_EPOCH is set | ||
58 | + set_source_date | ||
59 | |||
60 | for part in sanitycheck builddeps clean fetch unpack prepare mkusers build \ | ||
61 | $_check rootpkg; do | ||
62 | @@ -2159,6 +2164,9 @@ rootbld() { | ||
63 | # check early if we have abuild key | ||
64 | abuild-sign --installed | ||
65 | |||
66 | + # make sure SOURCE_DATE_EPOCH is set | ||
67 | + set_source_date | ||
68 | + | ||
69 | # networking business | ||
70 | sanitycheck | ||
71 | clean | ||
diff --git a/main/abuild/APKBUILD b/main/abuild/APKBUILD index b8c000403e..8b1aedeb02 100644 --- a/main/abuild/APKBUILD +++ b/main/abuild/APKBUILD | |||
@@ -2,7 +2,7 @@ | |||
2 | pkgname=abuild | 2 | pkgname=abuild |
3 | pkgver=3.5.0_rc1 | 3 | pkgver=3.5.0_rc1 |
4 | _ver=${pkgver%_git*} | 4 | _ver=${pkgver%_git*} |
5 | pkgrel=1 | 5 | pkgrel=2 |
6 | pkgdesc="Script to build Alpine Packages" | 6 | pkgdesc="Script to build Alpine Packages" |
7 | url="https://git.alpinelinux.org/cgit/abuild/" | 7 | url="https://git.alpinelinux.org/cgit/abuild/" |
8 | arch="all" | 8 | arch="all" |
@@ -22,6 +22,7 @@ options="suid !check" | |||
22 | pkggroups="abuild" | 22 | pkggroups="abuild" |
23 | source="https://dev.alpinelinux.org/archive/abuild/abuild-$_ver.tar.xz | 23 | source="https://dev.alpinelinux.org/archive/abuild/abuild-$_ver.tar.xz |
24 | 0001-Revert-abuild-make-built-package-reproducible.patch | 24 | 0001-Revert-abuild-make-built-package-reproducible.patch |
25 | 0001-abuild-Fix-abuild-rootbld.patch | ||
25 | " | 26 | " |
26 | 27 | ||
27 | builddir="$srcdir/$pkgname-$_ver" | 28 | builddir="$srcdir/$pkgname-$_ver" |
@@ -70,4 +71,5 @@ _rootbld() { | |||
70 | } | 71 | } |
71 | 72 | ||
72 | sha512sums="489198056857246adc7f61ca65e32d62717e872e11e284b83045f66a7b9b026cc6eb8d29215d94cee50a755f3320c1e8c51eca9a9763bd81da985b2f0713e4ee abuild-3.5.0_rc1.tar.xz | 73 | sha512sums="489198056857246adc7f61ca65e32d62717e872e11e284b83045f66a7b9b026cc6eb8d29215d94cee50a755f3320c1e8c51eca9a9763bd81da985b2f0713e4ee abuild-3.5.0_rc1.tar.xz |
73 | 5778fa633dd55f7b40f4368f75c214aaa234c9240a14255b7d69ee86253b7d480d2458eb8c6d6bf5b6824cb7f785e6d64416efc9639485e65203c17abdbccc8c 0001-Revert-abuild-make-built-package-reproducible.patch" | 74 | 5778fa633dd55f7b40f4368f75c214aaa234c9240a14255b7d69ee86253b7d480d2458eb8c6d6bf5b6824cb7f785e6d64416efc9639485e65203c17abdbccc8c 0001-Revert-abuild-make-built-package-reproducible.patch |
75 | a5ca8c1ee2f745f5cef36368c6b221f89cbf936e5e84f2fbf794a7aaa80ad6154a6ab74ff3f7a82c1e8703d5957a964ec408c01fb1b17245fa8c7d2e3aec619c 0001-abuild-Fix-abuild-rootbld.patch" | ||