diff options
author | Marco Tulio R Braga <marco.tulio@mtulio.eng.br> | 2018-09-02 03:46:45 -0400 |
---|---|---|
committer | Ben Kochie <superq@gmail.com> | 2018-09-02 09:46:45 +0200 |
commit | 05e55bddad50d79e6e5e28c7bfa7adc524135f41 (patch) | |
tree | 84d9d8616c066f5ce65cbb27472636bbede1ac79 | |
parent | 834e35112c4a7c7fbd3b6ff108d1042035297c55 (diff) | |
download | prometheus_node_collector-05e55bddad50d79e6e5e28c7bfa7adc524135f41.tar.bz2 prometheus_node_collector-05e55bddad50d79e6e5e28c7bfa7adc524135f41.tar.xz prometheus_node_collector-05e55bddad50d79e6e5e28c7bfa7adc524135f41.zip |
Fix typo on description of read_time_seconds_total (#1057)
Fix typo on unit description of metric `*read_time_seconds_total` from milliseconds to seconds.
Signed-off-by: Marco Tulio R Braga <marco.tulio@mtulio.eng.br>
-rw-r--r-- | collector/diskstats_linux.go | 2 | ||||
-rw-r--r-- | collector/fixtures/e2e-64k-page-output.txt | 2 | ||||
-rw-r--r-- | collector/fixtures/e2e-output.txt | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/collector/diskstats_linux.go b/collector/diskstats_linux.go index c80db4c..9b86eab 100644 --- a/collector/diskstats_linux.go +++ b/collector/diskstats_linux.go | |||
@@ -96,7 +96,7 @@ func NewDiskstatsCollector() (Collector, error) { | |||
96 | { | 96 | { |
97 | desc: prometheus.NewDesc( | 97 | desc: prometheus.NewDesc( |
98 | prometheus.BuildFQName(namespace, diskSubsystem, "read_time_seconds_total"), | 98 | prometheus.BuildFQName(namespace, diskSubsystem, "read_time_seconds_total"), |
99 | "The total number of milliseconds spent by all reads.", | 99 | "The total number of seconds spent by all reads.", |
100 | diskLabelNames, | 100 | diskLabelNames, |
101 | nil, | 101 | nil, |
102 | ), valueType: prometheus.CounterValue, | 102 | ), valueType: prometheus.CounterValue, |
diff --git a/collector/fixtures/e2e-64k-page-output.txt b/collector/fixtures/e2e-64k-page-output.txt index f1fa240..3e7f67a 100644 --- a/collector/fixtures/e2e-64k-page-output.txt +++ b/collector/fixtures/e2e-64k-page-output.txt | |||
@@ -350,7 +350,7 @@ node_disk_read_bytes_total{device="nvme0n1"} 2.377714176e+09 | |||
350 | node_disk_read_bytes_total{device="sda"} 5.13713216512e+11 | 350 | node_disk_read_bytes_total{device="sda"} 5.13713216512e+11 |
351 | node_disk_read_bytes_total{device="sr0"} 0 | 351 | node_disk_read_bytes_total{device="sr0"} 0 |
352 | node_disk_read_bytes_total{device="vda"} 1.6727491584e+10 | 352 | node_disk_read_bytes_total{device="vda"} 1.6727491584e+10 |
353 | # HELP node_disk_read_time_seconds_total The total number of milliseconds spent by all reads. | 353 | # HELP node_disk_read_time_seconds_total The total number of seconds spent by all reads. |
354 | # TYPE node_disk_read_time_seconds_total counter | 354 | # TYPE node_disk_read_time_seconds_total counter |
355 | node_disk_read_time_seconds_total{device="dm-0"} 46229.572 | 355 | node_disk_read_time_seconds_total{device="dm-0"} 46229.572 |
356 | node_disk_read_time_seconds_total{device="dm-1"} 0.084 | 356 | node_disk_read_time_seconds_total{device="dm-1"} 0.084 |
diff --git a/collector/fixtures/e2e-output.txt b/collector/fixtures/e2e-output.txt index bf10320..b3a236b 100644 --- a/collector/fixtures/e2e-output.txt +++ b/collector/fixtures/e2e-output.txt | |||
@@ -350,7 +350,7 @@ node_disk_read_bytes_total{device="nvme0n1"} 2.377714176e+09 | |||
350 | node_disk_read_bytes_total{device="sda"} 5.13713216512e+11 | 350 | node_disk_read_bytes_total{device="sda"} 5.13713216512e+11 |
351 | node_disk_read_bytes_total{device="sr0"} 0 | 351 | node_disk_read_bytes_total{device="sr0"} 0 |
352 | node_disk_read_bytes_total{device="vda"} 1.6727491584e+10 | 352 | node_disk_read_bytes_total{device="vda"} 1.6727491584e+10 |
353 | # HELP node_disk_read_time_seconds_total The total number of milliseconds spent by all reads. | 353 | # HELP node_disk_read_time_seconds_total The total number of seconds spent by all reads. |
354 | # TYPE node_disk_read_time_seconds_total counter | 354 | # TYPE node_disk_read_time_seconds_total counter |
355 | node_disk_read_time_seconds_total{device="dm-0"} 46229.572 | 355 | node_disk_read_time_seconds_total{device="dm-0"} 46229.572 |
356 | node_disk_read_time_seconds_total{device="dm-1"} 0.084 | 356 | node_disk_read_time_seconds_total{device="dm-1"} 0.084 |