Remove unreachable code. Test case for avoiding retries on PandoraException being raised.

2 files changed, 14 insertions, 2 deletions

diff --git a/pandora/transport.py b/pandora/transport.py
index 5681aec..bba1608 100644
--- a/pandora/transport.py
+++ b/pandora/transport.py
@@ -56,8 +56,6 @@ def retries(max_tries, exceptions=(Exception,)):
                             0.5, 2, max_tries - retries_left))
                     else:
                         raise
-                else:
-                    break
 
         return function
 
diff --git a/tests/test_pandora/test_transport.py b/tests/test_pandora/test_transport.py
index 6596a0e..394916b 100644
--- a/tests/test_pandora/test_transport.py
+++ b/tests/test_pandora/test_transport.py
@@ -1,5 +1,6 @@
 import time
 from unittest import TestCase
+from pandora.errors import PandoraException
 
 from pandora.py2compat import Mock, call
 
@@ -25,3 +26,16 @@ class TestTransport(TestCase):
 
         client.transport._start_request.assert_has_calls([call("method")])
         assert client.transport._start_request.call_count == 5
+
+    def test_call_should_not_retry_for_pandora_exceptions(self):
+        client = TestSettingsDictBuilder._build_minimal()
+
+        time.sleep = Mock()
+        client.transport._make_http_request = Mock(
+                side_effect=PandoraException("error_mock"))
+        client.transport._start_request = Mock()
+
+        client("method")
+
+        client.transport._start_request.assert_has_calls([call("method")])
+        assert client.transport._start_request.call_count == 1