Closes issue #261 on node_exporter. (#1403)

* Closes issue #261 on node_exporter.

Delegated mdstat parsing to procfs project. mdadm_linux.go now only exports the metrics.
-> Added disk labels: "fail", "spare", "active" to indicate disk status
-> hanged metric node_md_disks_total ==> node_md_disks_required
-> Removed test cases for mdadm_linux.go, as the functionality they tested for has been moved to procfs project.

Signed-off-by: Advait Bhatwadekar <advait123@ymail.com>

1 files changed, 137 insertions, 52 deletions

diff --git a/collector/fixtures/e2e-64k-page-output.txt b/collector/fixtures/e2e-64k-page-output.txt
index c4bbd6f..b7cf437 100644
--- a/collector/fixtures/e2e-64k-page-output.txt
+++ b/collector/fixtures/e2e-64k-page-output.txt
@@ -1078,6 +1078,7 @@ node_load5 0.37
 node_md_blocks{device="md0"} 248896
 node_md_blocks{device="md00"} 4.186624e+06
 node_md_blocks{device="md10"} 3.14159265e+08
+node_md_blocks{device="md101"} 322560
 node_md_blocks{device="md11"} 4.190208e+06
 node_md_blocks{device="md12"} 3.886394368e+09
 node_md_blocks{device="md120"} 2.095104e+06
@@ -1095,7 +1096,8 @@ node_md_blocks{device="md9"} 523968
 node_md_blocks_synced{device="md0"} 248896
 node_md_blocks_synced{device="md00"} 4.186624e+06
 node_md_blocks_synced{device="md10"} 3.14159265e+08
-node_md_blocks_synced{device="md11"} 4.190208e+06
+node_md_blocks_synced{device="md101"} 322560
+node_md_blocks_synced{device="md11"} 0
 node_md_blocks_synced{device="md12"} 3.886394368e+09
 node_md_blocks_synced{device="md120"} 2.095104e+06
 node_md_blocks_synced{device="md126"} 1.855870976e+09
@@ -1106,58 +1108,141 @@ node_md_blocks_synced{device="md4"} 4.883648e+06
 node_md_blocks_synced{device="md6"} 1.6775552e+07
 node_md_blocks_synced{device="md7"} 7.813735424e+09
 node_md_blocks_synced{device="md8"} 1.6775552e+07
-node_md_blocks_synced{device="md9"} 523968
-# HELP node_md_disks Total number of disks of device.
+node_md_blocks_synced{device="md9"} 0
+# HELP node_md_disks Number of active/failed/spare disks of device.
 # TYPE node_md_disks gauge
-node_md_disks{device="md0"} 2
-node_md_disks{device="md00"} 1
-node_md_disks{device="md10"} 2
-node_md_disks{device="md11"} 2
-node_md_disks{device="md12"} 2
-node_md_disks{device="md120"} 2
-node_md_disks{device="md126"} 2
-node_md_disks{device="md127"} 2
-node_md_disks{device="md219"} 3
-node_md_disks{device="md3"} 8
-node_md_disks{device="md4"} 2
-node_md_disks{device="md6"} 2
-node_md_disks{device="md7"} 4
-node_md_disks{device="md8"} 2
-node_md_disks{device="md9"} 4
-# HELP node_md_disks_active Number of active disks of device.
-# TYPE node_md_disks_active gauge
-node_md_disks_active{device="md0"} 2
-node_md_disks_active{device="md00"} 1
-node_md_disks_active{device="md10"} 2
-node_md_disks_active{device="md11"} 2
-node_md_disks_active{device="md12"} 2
-node_md_disks_active{device="md120"} 2
-node_md_disks_active{device="md126"} 2
-node_md_disks_active{device="md127"} 2
-node_md_disks_active{device="md219"} 0
-node_md_disks_active{device="md3"} 8
-node_md_disks_active{device="md4"} 0
-node_md_disks_active{device="md6"} 1
-node_md_disks_active{device="md7"} 3
-node_md_disks_active{device="md8"} 2
-node_md_disks_active{device="md9"} 4
-# HELP node_md_is_active Indicator whether the md-device is active or not.
-# TYPE node_md_is_active gauge
-node_md_is_active{device="md0"} 1
-node_md_is_active{device="md00"} 1
-node_md_is_active{device="md10"} 1
-node_md_is_active{device="md11"} 1
-node_md_is_active{device="md12"} 1
-node_md_is_active{device="md120"} 1
-node_md_is_active{device="md126"} 1
-node_md_is_active{device="md127"} 1
-node_md_is_active{device="md219"} 0
-node_md_is_active{device="md3"} 1
-node_md_is_active{device="md4"} 0
-node_md_is_active{device="md6"} 1
-node_md_is_active{device="md7"} 1
-node_md_is_active{device="md8"} 1
-node_md_is_active{device="md9"} 1
+node_md_disks{device="md0",state="active"} 2
+node_md_disks{device="md0",state="failed"} 0
+node_md_disks{device="md0",state="spare"} 0
+node_md_disks{device="md00",state="active"} 1
+node_md_disks{device="md00",state="failed"} 0
+node_md_disks{device="md00",state="spare"} 0
+node_md_disks{device="md10",state="active"} 2
+node_md_disks{device="md10",state="failed"} 0
+node_md_disks{device="md10",state="spare"} 0
+node_md_disks{device="md101",state="active"} 3
+node_md_disks{device="md101",state="failed"} 0
+node_md_disks{device="md101",state="spare"} 0
+node_md_disks{device="md11",state="active"} 2
+node_md_disks{device="md11",state="failed"} 1
+node_md_disks{device="md11",state="spare"} 2
+node_md_disks{device="md12",state="active"} 2
+node_md_disks{device="md12",state="failed"} 0
+node_md_disks{device="md12",state="spare"} 0
+node_md_disks{device="md120",state="active"} 2
+node_md_disks{device="md120",state="failed"} 0
+node_md_disks{device="md120",state="spare"} 0
+node_md_disks{device="md126",state="active"} 2
+node_md_disks{device="md126",state="failed"} 0
+node_md_disks{device="md126",state="spare"} 0
+node_md_disks{device="md127",state="active"} 2
+node_md_disks{device="md127",state="failed"} 0
+node_md_disks{device="md127",state="spare"} 0
+node_md_disks{device="md219",state="active"} 0
+node_md_disks{device="md219",state="failed"} 0
+node_md_disks{device="md219",state="spare"} 3
+node_md_disks{device="md3",state="active"} 8
+node_md_disks{device="md3",state="failed"} 0
+node_md_disks{device="md3",state="spare"} 2
+node_md_disks{device="md4",state="active"} 0
+node_md_disks{device="md4",state="failed"} 1
+node_md_disks{device="md4",state="spare"} 1
+node_md_disks{device="md6",state="active"} 1
+node_md_disks{device="md6",state="failed"} 1
+node_md_disks{device="md6",state="spare"} 1
+node_md_disks{device="md7",state="active"} 3
+node_md_disks{device="md7",state="failed"} 1
+node_md_disks{device="md7",state="spare"} 0
+node_md_disks{device="md8",state="active"} 2
+node_md_disks{device="md8",state="failed"} 0
+node_md_disks{device="md8",state="spare"} 2
+node_md_disks{device="md9",state="active"} 4
+node_md_disks{device="md9",state="failed"} 2
+node_md_disks{device="md9",state="spare"} 1
+# HELP node_md_disks_required Total number of disks of device.
+# TYPE node_md_disks_required gauge
+node_md_disks_required{device="md0"} 2
+node_md_disks_required{device="md00"} 1
+node_md_disks_required{device="md10"} 2
+node_md_disks_required{device="md101"} 3
+node_md_disks_required{device="md11"} 2
+node_md_disks_required{device="md12"} 2
+node_md_disks_required{device="md120"} 2
+node_md_disks_required{device="md126"} 2
+node_md_disks_required{device="md127"} 2
+node_md_disks_required{device="md219"} 0
+node_md_disks_required{device="md3"} 8
+node_md_disks_required{device="md4"} 0
+node_md_disks_required{device="md6"} 2
+node_md_disks_required{device="md7"} 4
+node_md_disks_required{device="md8"} 2
+node_md_disks_required{device="md9"} 4
+# HELP node_md_state Indicates the state of md-device.
+# TYPE node_md_state gauge
+node_md_state{device="md0",state="active"} 1
+node_md_state{device="md0",state="inactive"} 0
+node_md_state{device="md0",state="recovering"} 0
+node_md_state{device="md0",state="resync"} 0
+node_md_state{device="md00",state="active"} 1
+node_md_state{device="md00",state="inactive"} 0
+node_md_state{device="md00",state="recovering"} 0
+node_md_state{device="md00",state="resync"} 0
+node_md_state{device="md10",state="active"} 1
+node_md_state{device="md10",state="inactive"} 0
+node_md_state{device="md10",state="recovering"} 0
+node_md_state{device="md10",state="resync"} 0
+node_md_state{device="md101",state="active"} 1
+node_md_state{device="md101",state="inactive"} 0
+node_md_state{device="md101",state="recovering"} 0
+node_md_state{device="md101",state="resync"} 0
+node_md_state{device="md11",state="active"} 0
+node_md_state{device="md11",state="inactive"} 0
+node_md_state{device="md11",state="recovering"} 0
+node_md_state{device="md11",state="resync"} 1
+node_md_state{device="md12",state="active"} 1
+node_md_state{device="md12",state="inactive"} 0
+node_md_state{device="md12",state="recovering"} 0
+node_md_state{device="md12",state="resync"} 0
+node_md_state{device="md120",state="active"} 1
+node_md_state{device="md120",state="inactive"} 0
+node_md_state{device="md120",state="recovering"} 0
+node_md_state{device="md120",state="resync"} 0
+node_md_state{device="md126",state="active"} 1
+node_md_state{device="md126",state="inactive"} 0
+node_md_state{device="md126",state="recovering"} 0
+node_md_state{device="md126",state="resync"} 0
+node_md_state{device="md127",state="active"} 1
+node_md_state{device="md127",state="inactive"} 0
+node_md_state{device="md127",state="recovering"} 0
+node_md_state{device="md127",state="resync"} 0
+node_md_state{device="md219",state="active"} 0
+node_md_state{device="md219",state="inactive"} 1
+node_md_state{device="md219",state="recovering"} 0
+node_md_state{device="md219",state="resync"} 0
+node_md_state{device="md3",state="active"} 1
+node_md_state{device="md3",state="inactive"} 0
+node_md_state{device="md3",state="recovering"} 0
+node_md_state{device="md3",state="resync"} 0
+node_md_state{device="md4",state="active"} 0
+node_md_state{device="md4",state="inactive"} 1
+node_md_state{device="md4",state="recovering"} 0
+node_md_state{device="md4",state="resync"} 0
+node_md_state{device="md6",state="active"} 0
+node_md_state{device="md6",state="inactive"} 0
+node_md_state{device="md6",state="recovering"} 1
+node_md_state{device="md6",state="resync"} 0
+node_md_state{device="md7",state="active"} 1
+node_md_state{device="md7",state="inactive"} 0
+node_md_state{device="md7",state="recovering"} 0
+node_md_state{device="md7",state="resync"} 0
+node_md_state{device="md8",state="active"} 0
+node_md_state{device="md8",state="inactive"} 0
+node_md_state{device="md8",state="recovering"} 0
+node_md_state{device="md8",state="resync"} 1
+node_md_state{device="md9",state="active"} 0
+node_md_state{device="md9",state="inactive"} 0
+node_md_state{device="md9",state="recovering"} 0
+node_md_state{device="md9",state="resync"} 1
 # HELP node_memory_Active_anon_bytes Memory information field Active_anon_bytes.
 # TYPE node_memory_Active_anon_bytes gauge
 node_memory_Active_anon_bytes 2.068484096e+09