Make metrics better follow guidelines (#787)

* Improve stat linux metric names.

cpu is no longer used.

* node_cpu -> node_cpu_seconds_total for Linux

* Improve filesystem metric names with units

* Improve units and names of linux disk stats

Remove sector metrics, the bytes metrics cover those already.

* Infiniband counters should end in _total

* Improve timex metric names, convert to more normal units.

See
https://github.com/torvalds/linux/blob/3c073991eb417b6f785ddc6afbbdc369eb84aa6a/kernel/time/ntp.c#L909
for what stabil means, looks like a moving average of some form.

* Update test fixture

* For meminfo metrics that had "kB" units, add _bytes

* Interrupts counter should have _total

1 files changed, 2 insertions, 2 deletions

diff --git a/collector/infiniband_linux.go b/collector/infiniband_linux.go
index de8ce19..7c21976 100644
--- a/collector/infiniband_linux.go
+++ b/collector/infiniband_linux.go
@@ -57,8 +57,8 @@ func NewInfiniBandCollector() (Collector, error) {
                 "link_error_recovery_total":           {"link_error_recovery", "Number of times the link successfully recovered from an error state"},
                 "multicast_packets_received_total":    {"multicast_rcv_packets", "Number of multicast packets received (including errors)"},
                 "multicast_packets_transmitted_total": {"multicast_xmit_packets", "Number of multicast packets transmitted (including errors)"},
-                "port_data_received_bytes":            {"port_rcv_data", "Number of data octets received on all links"},
-                "port_data_transmitted_bytes":         {"port_xmit_data", "Number of data octets transmitted on all links"},
+                "port_data_received_bytes_total":      {"port_rcv_data", "Number of data octets received on all links"},
+                "port_data_transmitted_bytes_total":   {"port_xmit_data", "Number of data octets transmitted on all links"},
                 "unicast_packets_received_total":      {"unicast_rcv_packets", "Number of unicast packets received (including errors)"},
                 "unicast_packets_transmitted_total":   {"unicast_xmit_packets", "Number of unicast packets transmitted (including errors)"},
         }