diff options
author | Jerome Froelich <jeromefroelich@hotmail.com> | 2017-07-08 14:15:40 -0400 |
---|---|---|
committer | Ben Kochie <superq@gmail.com> | 2017-07-08 20:15:40 +0200 |
commit | cb14fff6c6f4e20fc2243eac9df980c46d8e80fa (patch) | |
tree | f6cba5a94e79e090a96ce591941f8113c80deffc /node_exporter_test.go | |
parent | 6e82fd1c563686230edf302f362314fb8a3c7ddb (diff) | |
download | prometheus_node_collector-cb14fff6c6f4e20fc2243eac9df980c46d8e80fa.tar.bz2 prometheus_node_collector-cb14fff6c6f4e20fc2243eac9df980c46d8e80fa.tar.xz prometheus_node_collector-cb14fff6c6f4e20fc2243eac9df980c46d8e80fa.zip |
[test] Call cmd.Start and cmd.Wait separately to avoid triggering race detector (#616)
* [test] Call cmd.Start and cmd.Wait separately to avoid triggering race detector
* [test] Enable race detector for tests
Diffstat (limited to 'node_exporter_test.go')
-rw-r--r-- | node_exporter_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/node_exporter_test.go b/node_exporter_test.go index 3b57949..b5c77af 100644 --- a/node_exporter_test.go +++ b/node_exporter_test.go | |||
@@ -107,9 +107,13 @@ func queryExporter(address string) error { | |||
107 | } | 107 | } |
108 | 108 | ||
109 | func runCommandAndTests(cmd *exec.Cmd, fn func(pid int) error) error { | 109 | func runCommandAndTests(cmd *exec.Cmd, fn func(pid int) error) error { |
110 | if err := cmd.Start(); err != nil { | ||
111 | return fmt.Errorf("failed to start command: %s", err) | ||
112 | } | ||
113 | |||
110 | errc := make(chan error) | 114 | errc := make(chan error) |
111 | go func() { | 115 | go func() { |
112 | if err := cmd.Run(); err != nil { | 116 | if err := cmd.Wait(); err != nil { |
113 | errc <- fmt.Errorf("execution of command failed: %s", err) | 117 | errc <- fmt.Errorf("execution of command failed: %s", err) |
114 | } else { | 118 | } else { |
115 | errc <- nil | 119 | errc <- nil |