Handle ParameterMissing exceptions due to missing ad tokens.

3 files changed, 85 insertions, 24 deletions

diff --git a/tests/test_pandora/test_client.py b/tests/test_pandora/test_client.py
index e7ef87f..24d9734 100644
--- a/tests/test_pandora/test_client.py
+++ b/tests/test_pandora/test_client.py
@@ -2,7 +2,8 @@ from unittest import TestCase
 
 from pandora.client import APIClient, BaseAPIClient
 from pandora.errors import InvalidAuthToken
-from pandora.py2compat import Mock, MagicMock, call, patch
+from pandora.py2compat import Mock, call, patch
+from tests.test_pandora.test_models import TestAdItem
 
 
 class TestAPIClientLogin(TestCase):
@@ -95,26 +96,8 @@ class TestGettingQualities(TestCase):
 
 class TestGettingAds(TestCase):
 
-    mock_ad_metadata_result = {
-        'audioUrlMap': {
-            'mediumQuality': {
-                'audioUrl': 'mock_med_url', 'bitrate': '64', 'protocol': 'http', 'encoding': 'aacplus'
-            },
-            'highQuality': {
-                'audioUrl': 'mock_high_url', 'bitrate': '64', 'protocol': 'http', 'encoding': 'aacplus'
-            },
-            'lowQuality': {
-                'audioUrl': 'mock_low_url', 'bitrate': '32', 'protocol': 'http', 'encoding': 'aacplus'}},
-            'clickThroughUrl': 'mock_click_url',
-            'imageUrl': 'mock_img_url',
-            'companyName': '',
-            'title': '',
-            'trackGain': '0.0',
-            'adTrackingTokens': ['mock_token_1', 'mock_token_2']
-    }
-
     def test_get_ad_item_(self):
-        with patch.object(APIClient, '__call__', return_value=self.mock_ad_metadata_result) as ad_metadata_mock:
+        with patch.object(APIClient, '__call__', return_value=TestAdItem.JSON_DATA) as ad_metadata_mock:
             transport = Mock(side_effect=[InvalidAuthToken(), None])
 
             client = APIClient(transport, None, None, None, None)
@@ -129,9 +112,9 @@ class TestGettingAds(TestCase):
                                                       supportAudioAds=True)])
 
     def test_get_ad_item_with_no_station_id_specified_raises_exception(self):
-            transport = Mock(side_effect=[InvalidAuthToken(), None])
+        transport = Mock(side_effect=[InvalidAuthToken(), None])
 
-            client = APIClient(transport, None, None, None, None)
-            client.get_ad_metadata = Mock()
+        client = APIClient(transport, None, None, None, None)
+        client.get_ad_metadata = Mock()
 
-            self.assertRaises(ValueError, client.get_ad_item, '', 'mock_token')
+        self.assertRaises(ValueError, client.get_ad_item, '', 'mock_token')
diff --git a/tests/test_pandora/test_models.py b/tests/test_pandora/test_models.py
index faee9a7..bb9e00a 100644
--- a/tests/test_pandora/test_models.py
+++ b/tests/test_pandora/test_models.py
@@ -1,5 +1,8 @@
 from unittest import TestCase
 from datetime import datetime
+from mock import mock
+from pandora import APIClient
+from pandora.models.pandora import AdItem, PlaylistModel
 
 import pandora.models as m
 
@@ -195,3 +198,46 @@ class TestPandoraDictListModel(TestCase):
                     "[TestSubModel(fieldS1='Foo', idx='foo'), "
                     "TestSubModel(fieldS1='Bar', idx='bar')]})")
         self.assertEqual(expected, repr(self.result))
+
+
+class TestAdItem(TestCase):
+
+    JSON_DATA = {
+        'audioUrlMap': {
+            'mediumQuality': {
+                'audioUrl': 'mock_med_url', 'bitrate': '64', 'protocol': 'http', 'encoding': 'aacplus'
+            },
+            'highQuality': {
+                'audioUrl': 'mock_high_url', 'bitrate': '64', 'protocol': 'http', 'encoding': 'aacplus'
+            },
+            'lowQuality': {
+                'audioUrl': 'mock_low_url', 'bitrate': '32', 'protocol': 'http', 'encoding': 'aacplus'}},
+            'clickThroughUrl': 'mock_click_url',
+            'imageUrl': 'mock_img_url',
+            'companyName': '',
+            'title': '',
+            'trackGain': '0.0',
+            'adTrackingTokens': ['mock_token_1', 'mock_token_2']
+    }
+
+    def setUp(self):
+        api_client_mock = mock.PropertyMock(spec=APIClient)
+        api_client_mock.default_audio_quality = APIClient.HIGH_AUDIO_QUALITY
+        self.result = AdItem.from_json(api_client_mock, self.JSON_DATA)
+
+    def test_is_ad_is_true(self):
+        assert self.result.is_ad is True
+
+    def test_register_ad(self):
+        self.result._api_client.register_ad = mock.PropertyMock()
+        self.result.register_ad('id_dummy')
+
+        assert self.result._api_client.register_ad.called
+
+    def test_prepare_playback(self):
+        with mock.patch.object(PlaylistModel, 'prepare_playback') as super_mock:
+
+            self.result.register_ad = mock.PropertyMock()
+            self.result.prepare_playback()
+            assert self.result.register_ad.called
+            assert super_mock.called
diff --git a/tests/test_pydora/test_utils.py b/tests/test_pydora/test_utils.py
new file mode 100644
index 0000000..8298e28
--- /dev/null
+++ b/tests/test_pydora/test_utils.py
@@ -0,0 +1,32 @@
+from unittest import TestCase
+from pandora import errors
+
+from pandora.client import APIClient
+from pandora.errors import InvalidAuthToken
+from pandora.models.pandora import Station, AdItem
+from pandora.py2compat import Mock, patch
+from pydora.utils import iterate_forever
+from tests.test_pandora.test_models import TestAdItem
+
+
+class TestIterateForever(TestCase):
+
+    def setUp(self):
+        transport = Mock(side_effect=[InvalidAuthToken(), None])
+        client = APIClient(transport, None, None, None, None)
+        client._authenticate = Mock()
+        self.result = AdItem.from_json(client, TestAdItem.JSON_DATA)
+
+    def test_handle_missing_params_exception_due_to_missing_ad_tokens(self):
+        with patch.object(APIClient, 'register_ad', side_effect=errors.ParameterMissing("ParameterMissing")):
+
+            station = Mock(spec=Station)
+            station.token = 'mock_token'
+
+            self.result.tracking_tokens = []
+
+            station.get_playlist.return_value = iter([self.result])
+            station_iter = iterate_forever(station.get_playlist)
+
+            next_track = station_iter.next()
+            self.assertEqual(self.result, next_track)