diff options
author | Devin J. Pohly <djpohly@gmail.com> | 2018-02-24 16:16:12 -0600 |
---|---|---|
committer | Devin J. Pohly <djpohly@gmail.com> | 2018-02-25 21:56:26 -0600 |
commit | 30683c70ab62fd37b5921cf72077b9aef2cb842e (patch) | |
tree | f81bf19a9cf62cd9ac97c4c7e4eab6a4cc131c89 /st.h | |
parent | a3beb626d2dae9d4d0883c7c8cb6ba58b0609105 (diff) | |
download | st-patched-30683c70ab62fd37b5921cf72077b9aef2cb842e.tar.bz2 st-patched-30683c70ab62fd37b5921cf72077b9aef2cb842e.tar.xz st-patched-30683c70ab62fd37b5921cf72077b9aef2cb842e.zip |
Limit usage of extern to config.h globals
Prefer passing arguments to declaring external global variables. The
only remaining usage of extern is for config.h variables which are
needed in st.c instead of x.c (where it is now included).
Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
Diffstat (limited to 'st.h')
-rw-r--r-- | st.h | 9 |
1 files changed, 2 insertions, 7 deletions
@@ -125,7 +125,8 @@ int tattrset(int); | |||
125 | void tnew(int, int); | 125 | void tnew(int, int); |
126 | void tresize(int, int); | 126 | void tresize(int, int); |
127 | void tsetdirtattr(int); | 127 | void tsetdirtattr(int); |
128 | void ttynew(char *, char *, char **); | 128 | void ttyhangup(void); |
129 | int ttynew(char *, char *, char *, char **); | ||
129 | size_t ttyread(void); | 130 | size_t ttyread(void); |
130 | void ttyresize(int, int); | 131 | void ttyresize(int, int); |
131 | void ttywrite(const char *, size_t, int); | 132 | void ttywrite(const char *, size_t, int); |
@@ -147,13 +148,7 @@ void *xmalloc(size_t); | |||
147 | void *xrealloc(void *, size_t); | 148 | void *xrealloc(void *, size_t); |
148 | char *xstrdup(char *); | 149 | char *xstrdup(char *); |
149 | 150 | ||
150 | /* Globals */ | ||
151 | extern int cmdfd; | ||
152 | extern pid_t pid; | ||
153 | extern int oldbutton; | ||
154 | |||
155 | /* config.h globals */ | 151 | /* config.h globals */ |
156 | extern char *shell; | ||
157 | extern char *utmp; | 152 | extern char *utmp; |
158 | extern char *stty_args; | 153 | extern char *stty_args; |
159 | extern char *vtiden; | 154 | extern char *vtiden; |