clients/netbox: better API error handlingclients/netbox/v3.1.0

2 files changed, 21 insertions, 0 deletions

diff --git a/clients/netbox/client.go b/clients/netbox/client.go
index 43ef64c..0cad733 100644
--- a/clients/netbox/client.go
+++ b/clients/netbox/client.go
@@ -36,6 +36,14 @@ func (c *BasicNetboxClient) makeRequestRaw(ctx context.Context, method, u string
         }
         defer res.Body.Close()
 
+        if res.StatusCode != http.StatusOK {
+                apiError := &ApiError{Status: res.StatusCode}
+                if err = json.NewDecoder(res.Body).Decode(apiError); err != nil {
+                        return fmt.Errorf("Netbox JSON decode error while parsing error with status %d: %w", res.StatusCode, err)
+                }
+                return apiError
+        }
+
         if err = json.NewDecoder(res.Body).Decode(o); err != nil {
                 return err
         }
diff --git a/clients/netbox/model.go b/clients/netbox/model.go
index 78f2ca6..40c4aa6 100644
--- a/clients/netbox/model.go
+++ b/clients/netbox/model.go
@@ -1,5 +1,18 @@
 package netbox
 
+import "fmt"
+
+type ApiError struct {
+        Status int
+        Detail string `json:"detail"`
+}
+
+func (e *ApiError) Error() string {
+        return fmt.Sprintf("Netbox API Error (Status %d): %s", e.Status, e.Detail)
+}
+
+var _ error = (*ApiError)(nil)
+
 type LabeledInt struct {
         Value int    `json:"value"`
         Label string `json:"label"`